fix(archiver): clear the waitForSpace timeout on the success path - #89
Merged
Conversation
Follow-up to #88. `waitForSpace` never cleared its timeout timer, so every satisfied space claim left a pending timer alive for the full `maxDiskSpaceWaitSeconds`. The late fire is harmless on its own — `Promise.race` has already settled and both branches are handled, so there's no unhandled rejection — but this is a long-lived worker and #88 is specifically about not leaking per-job resources. Clear it in a `finally` so both the success and failure paths release the timer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #88.
waitForSpacenever cleared its timeout timer, so every satisfied space claim left a pending timer alive for the fullmaxDiskSpaceWaitSeconds.The late fire is harmless on its own —
Promise.racehas already settled and both branches are handled, so there's no unhandled rejection — but this is a long-lived worker and #88 is specifically about not leaking per-job resources. Clearing it in afinallycovers both the success and failure paths.Found while reviewing #88 against the live prod wedge (all 5 worker slots held 2.3–8.5 days, 21 jobs backed up in
wait).npx tsc --noEmitclean; all 31 archiver tests pass.🤖 Generated with Claude Code